Don't assume repl input is only 2 statements #7530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrf
reviewed
Nov 10, 2019
Contributor
julienrf
left a comment
julienrf
left a comment
There was a problem hiding this comment.
Do we have tests for that?
Member
Author
|
I've checked and there are no tests or framework for |
bishabosha
force-pushed
the
issue/7529
branch
from
47391e6 to
1e4dd49
Compare
Contributor
|
@bishabosha could you make the commit message start with |
bishabosha
force-pushed
the
issue/7529
branch
from
1e4dd49 to
f9c7f1a
Compare
Member
Author
|
I've adjusted the commit message |
julienrf
approved these changes
Nov 11, 2019
bishabosha
force-pushed
the
issue/7529
branch
from
f9c7f1a to
e028fb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7529
each statement in repl input that contains a
defannotated with@maingenerates a new typedef that appears after the typedef containing the repl input