Fix #7683: Fix CompilationUnit handling in Context#withSource #7691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
careful-compilation-unit
branch
from
34bac60 to
9a32a2c
Compare
In e07a728, I changed Context#withSource to set a new CompilationUnit based on the source if no compilation unit is currently set (always having a CompilationUnit set is now needed since I moved the fresh name generator inside CompilationUnit), however CompilationUnit#apply will error out if the source file does not exist, which might happen for library code. Fixed by adding a parameter to disable this check, but this is not very pretty and we should really try to design a better way to distinguish between user source files and source files we happen to know the name of because it's stored in Tasty.
smarter
force-pushed
the
careful-compilation-unit
branch
from
9a32a2c to
31d095b
Compare
smarter
force-pushed
the
careful-compilation-unit
branch
from
31d095b to
35b79c5
Compare
|
This fixed the issue |
nicolasstucki
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In e07a728, I changed
Context#withSource to set a new CompilationUnit based on the source if
no compilation unit is currently set (always having a CompilationUnit
set is now needed since I moved the fresh name generator inside
CompilationUnit), however CompilationUnit#apply will error out if the
source file does not exist, which might happen for library code.
Fixed by adding a parameter to disable this check, but this is not very
pretty and we should really try to design a better way to distinguish
between user source files and source files we happen to know the name of
because it's stored in Tasty.