Skip to content

Fix #7878: Make sure implicit match case bindings are properly substi… #7902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abgruszecki merged 1 commit into from
Jan 7, 2020
Merged

Fix #7878: Make sure implicit match case bindings are properly substi… #7902

abgruszecki merged 1 commit into from
Jan 7, 2020

Conversation

@odersky
Copy link
Contributor

@odersky odersky commented Jan 6, 2020

…tuted

@odersky odersky requested a review from abgruszecki January 6, 2020 12:01
@odersky odersky added the fasttrack Simple fix. Reviewer should merge or apply additional changes directly. label Jan 6, 2020
abgruszecki
abgruszecki approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@abgruszecki abgruszecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abgruszecki abgruszecki merged commit d6be581 into scala:master Jan 7, 2020
@abgruszecki abgruszecki deleted the fix-#7878 branch January 7, 2020 15:18
@eejbyfeldt eejbyfeldt mentioned this pull request Dec 29, 2025
Open
eejbyfeldt added a commit to eejbyfeldt/scala3 that referenced this pull request Dec 29, 2025
@eejbyfeldt
Also substitute case bindings in symbols
25ae44e 
The fix for scala#24813 is the also updating the symbol in the line
```
to.foreach(sym => sym.info = sym.info.substSym(from, to))
```

the other changes are more clean up so we only have to do that
substitution once. Before scala#7902
the substitution are done both inside substBindings and afterwards. But
if done after it the partial substitutions inside are redundant. So this
changes it so we only call `subst` one place.

It unclear if we expect `subst` to already do this replace? If we do
then we should probably fix this in that implementation instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@abgruszecki abgruszecki abgruszecki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@abgruszecki abgruszecki

Labels

fasttrack Simple fix. Reviewer should merge or apply additional changes directly.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@odersky @abgruszecki