Fixed classpath bug #8004
Fixed classpath bug #8004
Conversation
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Commit Messages
We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).
Please stick to these guidelines for commit messages:
- Separate subject from body with a blank line
- When fixing an issue, start your commit message with
Fix #<ISSUE-NBR>:- Limit the subject line to 72 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line ("Add" instead of "Added")
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
adapted from https://chris.beams.io/posts/git-commit
Have an awesome day! ☀️
| .mkString( | ||
| "", | ||
| File.pathSeparator, | ||
| if (suffixClasspath.isEmpty) "" else File.pathSeparator + suffixClasspath |
There was a problem hiding this comment.
The current version in #7953 has been updated. You should take the current version.
There was a problem hiding this comment.
I meant, to copy the code in https://github.com/lampepfl/dotty/pull/7953/files#diff-0cf1d278cf2ee8dca0cb2b7bcb62348aR75
There was a problem hiding this comment.
Should we take this as a sign to refactor into one method?
There was a problem hiding this comment.
Yes, but I would leave it for a future PR. I have a bigger refactoring coming that will address that.
There was a problem hiding this comment.
I opened #8020 for this refactoring.
There was a problem hiding this comment.
The current fix works, but could slow on deeply nested classloaders. This potential performance hit will be fixed in #8020.
|
@gzoller I decided to merge it as it does fix the current issue. |
|
Ok, thanks! Will delete my fork. |
@smarter just posted a PR that fixed a classpath issue in QuoteDriver. The exact same code is also in ConsumeTasty (compiler subdir), and it's been causing problems in Tasty inspection. I cut/paste @smarter's fix into ConsumeTasty so it will work the same way. I didn't refactor to avoid DRY because this is my first commit and I don't feel confident I understand the project structure yet.
I've signed the CLA.