Fix #7597: Refine checks whether a deferred term member is implemented #8332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mented The check for a concrete class used to be simply that its `abstractTermMembers` are empty. However, i7597.scala shows that this is not enough. The problem is that abstractTermMembers is based on signatures. It will not include a member as long as there is a concrete member with the same signature. But as scala#7597 shows it's possible for a concrete member to have the same signature as an abstract one but still not have a matching type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for a concrete class used to be simply that its
abstractTermMembersare empty. However, i7597.scala shows that this is not enough. The problem is
that abstractTermMembers is based on signatures. It will not include a member
as long as there is a concrete member with the same signature.
But as #7597 shows it's possible for a concrete member to have the same signature
as an abstract one but still not have a matching type.