Avoid overcompilation involving inline or annotation trees #8359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/8359/ to see the changes. Benchmarks is based on merging with master (228e593) |
|
test performance with #sbt please |
|
performance test scheduled: 1 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/8359/ to see the changes. Benchmarks is based on merging with master (811dc19) |
| @@ -624,6 +623,6 @@ private class ExtractAPICollector(implicit val ctx: Context) extends ThunkHolder | |||
| // junit tests are annotated @org.junit.Test). | |||
| api.Annotation.of( | |||
| apiType(annot.tree.tpe), // Used by sbt to find tests to run | |||
| Array(api.AnnotationArgument.of("FULLTREE", annot.tree.show))) | |||
| Array(api.AnnotationArgument.of("FULLTREE", annot.tree.toString))) | |||
There was a problem hiding this comment.
The comment above also needs to be updated
We used to pretty-print trees in the API info we send to sbt, but the pretty-printed output seems to be unstable leading to overcompilation, so just use the raw trees instead (this should also be faster).
smarter
force-pushed
the
overcompilation-print
branch
from
de03284 to
b952d41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to pretty-print trees in the API info we send to sbt, but the
pretty-printed output seems to be unstable leading to overcompilation,
so just use the raw trees instead (this should also be faster).