Skip to content

doc(export): add link to note #8381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2020
Merged

doc(export): add link to note #8381

merged 1 commit into from
Feb 26, 2020

Conversation

robstoll
Copy link
Contributor

No description provided.

Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PRs are very much appreciated, but could you try batching your documentation changes in fewer PRs ? It's easier to review and it strains our CI less.

@robstoll
Copy link
Contributor Author

The thing is, I usually do those PRs when I am using the public transport system where I have a few minutes and never know if I can finish something or not. I am creating those from my phone and hence it is easier for me to create small PRs but I understand that your concern. So far I tried to do one PR per file which is easy enough as I can simply click on edit file and do the changes. Changing another file in the same PR is already more cumbersome for me. How about the following compromise:

  • I create several branches, one per file
  • I merge those branches into one branch and create then a PR
  • you can still squash the commits during merge

Would that be a suitable way for you?

Regarding CI, IMO we should improve there and not improve on the contributor side. I hope your CI is able to set triggers for jobs and base them on changes in the commit. This way it would be easy to disable all the jobs which are not checking the docs in case changes are only in /docs/...
I can try to help out if required

@smarter
Copy link
Member

smarter commented Feb 26, 2020

Would that be a suitable way for you?

Sure!

@smarter smarter merged commit 1955f75 into scala:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants