Skip to content

Fix #8690: the signature for product should come from expected type #8698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 14, 2020
Merged

Fix #8690: the signature for product should come from expected type #8698

merged 13 commits into from
Apr 14, 2020

Conversation

liufengyun
Copy link
Contributor

Fix #8690: the signature for product should come from expected type

@liufengyun
Add test
911a818
@liufengyun
Add more test
00ee7e2
@liufengyun
Fix CI
aff3b08
@liufengyun
Fix test
ba2b678 
We need to adapt the test, otherwise the exhaustivity warning,
which comes before, will stop the compilation, the isInstanceOf
warnings will not be issued.
@liufengyun liufengyun marked this pull request as ready for review April 9, 2020 14:55
@liufengyun liufengyun mentioned this pull request Apr 9, 2020
Closed
@liufengyun
Copy link
Contributor Author

liufengyun commented Apr 9, 2020 •
edited
Loading

test performance with #fast please

@liufengyun liufengyun requested a review from nicolasstucki April 9, 2020 15:16
@dottybot
Copy link
Member

dottybot commented Apr 9, 2020

performance test scheduled: 1 job(s) in queue, 0 running.

@dottybot
Copy link
Member

dottybot commented Apr 9, 2020

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/8698/ to see the changes.

Benchmarks is based on merging with master (a6b47e4)

@liufengyun
Copy link
Contributor Author

test performance please

@dottybot
Copy link
Member

dottybot commented Apr 9, 2020

performance test scheduled: 1 job(s) in queue, 0 running.

@dottybot
Copy link
Member

dottybot commented Apr 9, 2020

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/8698/ to see the changes.

Benchmarks is based on merging with master (a6b47e4)

@liufengyun
Copy link
Contributor Author

test performance please

@dottybot
Copy link
Member

dottybot commented Apr 9, 2020

performance test scheduled: 1 job(s) in queue, 1 running.

@dottybot
Copy link
Member

dottybot commented Apr 9, 2020

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/8698/ to see the changes.

Benchmarks is based on merging with master (f64e879)

nicolasstucki
nicolasstucki approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification

compiler/src/dotty/tools/dotc/transform/patmat/Space.scala
val unappSym = unapp.symbol
def caseClass = unappSym.owner.linkedClass

// println("scrutineeTp = " + scrutineeTp.show)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to remove this

@nicolasstucki nicolasstucki removed their assignment Apr 14, 2020
@nicolasstucki nicolasstucki merged commit f23da5e into scala:master Apr 14, 2020
@nicolasstucki nicolasstucki deleted the fix-i8690 branch April 14, 2020 05:45
@smarter smarter mentioned this pull request Apr 14, 2020
Closed
@liufengyun liufengyun mentioned this pull request Jun 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@liufengyun liufengyun

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Spurious exhaustiveness warning for union of tuple types

3 participants

@liufengyun @dottybot @nicolasstucki