-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Allow structural anonymous classes #9201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,29 +1,43 @@ | ||
package scala.reflect | ||
|
||
class Selectable(val receiver: Any) extends AnyVal with scala.Selectable { | ||
def selectDynamic(name: String): Any = { | ||
val rcls = receiver.getClass | ||
try { | ||
/** A class that implements structural selections using Java reflection. | ||
* It can be used as a supertrait of a class or be made available | ||
* as an implicit conversion via `reflectiveSelectable`. | ||
*/ | ||
trait Selectable extends scala.Selectable: | ||
|
||
/** The value from which structural members are selected. | ||
* By default this is the Selectable instance itself, but it can | ||
* be overridden. | ||
*/ | ||
protected def selectedValue: Any = this | ||
|
||
/** Select member with given name */ | ||
def selectDynamic(name: String): Any = | ||
val rcls = selectedValue.getClass | ||
try | ||
val fld = rcls.getField(name) | ||
ensureAccessible(fld) | ||
fld.get(receiver) | ||
} | ||
catch { | ||
case ex: NoSuchFieldException => | ||
applyDynamic(name)() | ||
} | ||
} | ||
fld.get(selectedValue) | ||
catch case ex: NoSuchFieldException => | ||
applyDynamic(name)() | ||
|
||
def applyDynamic(name: String, paramTypes: ClassTag[_]*)(args: Any*): Any = { | ||
val rcls = receiver.getClass | ||
/** Select method and apply to arguments. | ||
* @param name The name of the selected method | ||
* @param paramTypes The class tags of the selected method's formal parameter types | ||
* @param args The arguments to pass to the selected method | ||
*/ | ||
def applyDynamic(name: String, paramTypes: ClassTag[_]*)(args: Any*): Any = | ||
val rcls = selectedValue.getClass | ||
val paramClasses = paramTypes.map(_.runtimeClass) | ||
val mth = rcls.getMethod(name, paramClasses: _*) | ||
ensureAccessible(mth) | ||
mth.invoke(receiver, args.asInstanceOf[Seq[AnyRef]]: _*) | ||
} | ||
} | ||
mth.invoke(selectedValue, args.asInstanceOf[Seq[AnyRef]]: _*) | ||
|
||
object Selectable: | ||
|
||
object Selectable { | ||
implicit def reflectiveSelectable(receiver: Any): Selectable = | ||
new Selectable(receiver) | ||
} | ||
/** An implicit conversion that turns a value into a Selectable | ||
* such that structural selections are performed on that value. | ||
*/ | ||
implicit def reflectiveSelectable(x: Any): Selectable = | ||
new Selectable { override val selectedValue = x } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
@main def Test = | ||
val x = | ||
class C extends reflect.Selectable: | ||
def name: String = "hello" | ||
new C | ||
|
||
val y = new reflect.Selectable: | ||
def name: String = "hello" | ||
|
||
assert(x.name == "hello") | ||
assert(y.name == "hello") |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here you write
scala.Selectable
but above you writereflect.Selectable
(and also in the tests). I assume this is a typo, but perhapsscala.Selectable
is also a thing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, scala.reflect.Selectable is the java-reflection-based implementation of the scala.Selectable mechanism https://github.com/lampepfl/dotty/blob/master/library/src/scala/Selectable.scala https://github.com/lampepfl/dotty/blob/master/library/src/scala/reflect/Selectable.scala
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Thanks for the clarification. (I never use these due to performance anxiety associated with reflection, so I had forgotten about that).