Keep inlined final vals in generated code #9261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
keep-inlined-final-vals-in-generated-code
branch
7 times, most recently
from
77c1bb0 to
b2353f3
Compare
bishabosha
requested changes
Jul 3, 2020
There was a problem hiding this comment.
it seems that a final val constant is not stable in TASTy unless a stable path is requested for it:
object Consts {
final val msg = "Hello World" // not stable
}
object TestConsts {
def foo = Consts.msg
}object Consts {
final val msg = "Hello World" // now it is stable because of a use site
}
object TestConsts {
def foo: Consts.msg.type = Consts.msg
}
Though final vals with constants are guarantieed to be inlined in Dotty, we need to keep the definition in case these are used from Scala 2. Scala 2 misses some inlining oportunities.
nicolasstucki
force-pushed
the
keep-inlined-final-vals-in-generated-code
branch
from
b2353f3 to
2a8c275
Compare
|
@bishabosha that is not related to the changes in this PR. Could you open an issue for it? |
|
@nicolasstucki I made the issue, otherwise this looks good to me |
bishabosha
approved these changes
Jul 3, 2020
sjrd
added a commit
to sjrd/dotty
that referenced
this pull request
Jul 16, 2020
sjrd
added a commit
to sjrd/dotty
that referenced
this pull request
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though final vals with constants are guarantieed to be inlined in Dotty,
we need to keep the definition in case these are used from Scala 2.
Scala 2 misses some inlining oportunities.