Disallow curried dependent context function types #9303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicolasstucki If you produce a new bootstrap compiler it would be good to have this PR in it as well. That would allow me to continue with my experiment to use CFTs in the compiler. Right now that's blocked since some methods that would have a CFT result type also have return statements. |
| .takeWhile(_.isAnonymousFunction) | ||
| .toList | ||
| .reverse | ||
| .map(_.paramSymss.head) |
There was a problem hiding this comment.
This map can be done before the toList
There was a problem hiding this comment.
Yes, but that's not necessarily better, or is it? We are talking of iterators of length 1 - 2 on average
There was a problem hiding this comment.
Then the extra allocation should be fine.
nicolasstucki
approved these changes
Jul 7, 2020
|
This change will be available in the compiler once #9311 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't implement them yet. Better to disallow them outright than to try map them
to something wrong and have obscure follow-on errors.
Also: Implement returns in methods with context function result types
Previously, a return in a method with a CFT result type crashed the typer.