Skip to content

Change implicit to using #9333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Jul 10, 2020
Merged

Change implicit to using #9333

merged 41 commits into from
Jul 10, 2020

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jul 9, 2020

No description provided.

@odersky
Copy link
Contributor Author

odersky commented Jul 9, 2020

test performance please

@dottybot
Copy link
Member

dottybot commented Jul 9, 2020

performance test scheduled: 1 job(s) in queue, 0 running.

@dottybot
Copy link
Member

dottybot commented Jul 9, 2020

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/9333/ to see the changes.

Benchmarks is based on merging with master (480f95f)

@nicolasstucki nicolasstucki mentioned this pull request Jul 10, 2020
Merged
@odersky
Copy link
Contributor Author

odersky commented Jul 10, 2020

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 0 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/9333/ to see the changes.

Benchmarks is based on merging with master (480f95f)

@odersky
Move plugins to ContextBase
159486a 
Plugins creates two variables which are the same for all contexts in a run.
So they should go to ContextBase, not contexts. For background: We are creating
upwards of 500'000 contexts per second. So every variable in there counts.
@odersky
Copy link
Contributor Author

odersky commented Jul 10, 2020

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 1 running.

@odersky
Copy link
Contributor Author

odersky commented Jul 10, 2020

I am going to merge this ASAP. I believe it's far too large and uninteresting to review, and it will get out of sync very quickly.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/9333/ to see the changes.

Benchmarks is based on merging with master (e6bb414)

@odersky odersky merged commit aa64078 into scala:master Jul 10, 2020
@odersky odersky deleted the change-using branch July 10, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soronpo soronpo soronpo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odersky @dottybot @soronpo