Skip to content

Fix CompilationUnit.apply #9387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2020
Merged

Fix CompilationUnit.apply #9387

merged 1 commit into from
Jul 19, 2020

Conversation

azolotko
Copy link
Contributor

I assume this is the way CompilationUnit.apply was intended to be implemented.

dottybot
dottybot reviewed Jul 18, 2020
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@TheElectronWill
Copy link
Contributor

Good catch!
You should (re)start from the latest master instead of a 2019 commit. The bug is still there but the file has changed, hence the conflicts.

@azolotko
Copy link
Contributor Author

@TheElectronWill I've rebased, thanks!

@TheElectronWill TheElectronWill merged commit 21a90aa into scala:master Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottybot dottybot dottybot left review comments

+1 more reviewer

@TheElectronWill TheElectronWill TheElectronWill approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azolotko @TheElectronWill @dottybot