Fix #7312: Choose root imports based on the source file #9394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheElectronWill
force-pushed
the
fix/7312
branch
5 times, most recently
from
d3e1ae6 to
7e05e1e
Compare
TheElectronWill
force-pushed
the
fix/7312
branch
from
7e05e1e to
c749085
Compare
Instead of setting the scala root imports in the rootContext, set them later and choose the right imports depending on the language (java or scala).
TheElectronWill
force-pushed
the
fix/7312
branch
from
c749085 to
6990aab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use different root imports for java and scala files, so that (for instance)
Longmeansjava.lang.Longwhen parsing java files (unlessscala.Longis imported, of course).This also paves the way for
-Yimports.