Expose ofErasedClass in Reflection #9851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Sep 23, 2020
nicolasstucki
suggested changes
Sep 23, 2020
Co-authored-by: Nicolas Stucki <nicolas.stucki@gmail.com>
nicolasstucki
approved these changes
Sep 23, 2020
|
Hi Nicolas, please confirm, but I don't think the changes you wanted to Liftable happened when I clicked the accept changes button. I made the Liftable changes on my branch just now (takes a while for the tests to run). Let me know if we need to reopen the PR and pull in this change too. |
|
It fine like that, I already added that change directly in #9818. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9850
Change to expose Reflection.Type.ofErasedClass, which was already present in CompilerInterface. I need a way to create a Type from a class instance, which broke when Reflection.Type.apply() was recently removed. This change re-introduces the functionality with the naming already present in the interface.