Refactor Reflect implicit search #9863
Conversation
nicolasstucki
force-pushed
the
refactor-Reflect-implicit-search
branch
from
9546cc5 to
8eff3e9
Compare
nicolasstucki
force-pushed
the
refactor-Reflect-implicit-search
branch
2 times, most recently
from
fcf96de to
663134e
Compare
| protected val ImplicitSearchSuccessTypeTest: TypeTest[ImplicitSearchResult, ImplicitSearchSuccess] | ||
| trait ImplicitSearchModule { self: ImplicitSearch.type => | ||
| /** Find a given instance of type `T` in the current scope. | ||
| * Return an `ImplicitSearch`. |
There was a problem hiding this comment.
Will it find Scala2 implicit instances? The "current scope' needs some explanation.
There was a problem hiding this comment.
Maybe change the current scope to the current scope (e.g., the call site of a macro)?
| @@ -5,7 +5,7 @@ inline def f: Any = ${ fImpl } | |||
|
|
|||
| private def fImpl (using qctx: QuoteContext) : Expr[Unit] = { | |||
| import qctx.tasty._ | |||
| searchImplicit(('[A]).unseal.tpe) match { | |||
| ImplicitSearch(('[A]).unseal.tpe) match { | |||
There was a problem hiding this comment.
Minor: usually the convention for .apply methods is to simply construct an object from arguments. It seems here Implicits.search might be more idiomatic.
There was a problem hiding this comment.
Indeed. I will try it out
nicolasstucki
force-pushed
the
refactor-Reflect-implicit-search
branch
from
663134e to
83e93a8
Compare
|
|
||
| type ImplicitSearchResult <: AnyRef | ||
| /** Result of a given instance search */ | ||
| type ImplicitSearch <: AnyRef |
There was a problem hiding this comment.
I find the previous name is better for readability. Meanwhile, maybe use "implicit instance search" in the docs for consistency and precision: as Scala2 implicits are not given instances.
There was a problem hiding this comment.
I will go back to ImplicitSearchResult now that we don't have to use it in source
| protected val ImplicitSearchSuccessTypeTest: TypeTest[ImplicitSearchResult, ImplicitSearchSuccess] | ||
| trait ImplicitSearchModule { self: ImplicitSearch.type => | ||
| /** Find a given instance of type `T` in the current scope. | ||
| * Return an `ImplicitSearch`. |
There was a problem hiding this comment.
Maybe change the current scope to the current scope (e.g., the call site of a macro)?
nicolasstucki
force-pushed
the
refactor-Reflect-implicit-search
branch
from
83e93a8 to
918ae10
Compare
Move implicit search method into implicit search module. This makes the Relfect API more design more homogeneous.
nicolasstucki
force-pushed
the
refactor-Reflect-implicit-search
branch
from
918ae10 to
2fdc20b
Compare
No description provided.