Fix #8521: Remove PackageDef and use Symbol directly #9913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PackageDef was originally added to try to encode trees in the API without the use of symbols. Now that we have symbols all the package def logic is redundant. At the time we assumed that we would be able to have a tree for all Symbol, but this has not been the case since the introduction of NoSymbol. Now we handle the `tree` of a package def the same way we did the one of a NoSymbol. * Remove `PackageDef` * Add `members` method on `Symbol` * Disallow package symbols in `Symbol.tree` as done with `NoSymbol`
nicolasstucki
force-pushed
the
fix-#8521
branch
from
67fe84e to
bd52edf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PackageDef was originally added to try to encode trees in the API without the use of symbols. Now that we have symbols all the package def logic is redundant.
At the time we assumed that we would be able to have a tree for all Symbol, but this has not been the case since the introduction of NoSymbol.
Now we handle the
treeof a package def the same way we did the one of a NoSymbol.PackageDefmembersmethod onSymbolSymbol.treeas done withNoSymbol