Rework Reflect Constant #9914
Merged
Rework Reflect Constant #9914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
rework-reflect-constant
branch
from
e8b64b4 to
933ce20
Compare
smarter
reviewed
Sep 29, 2020
nicolasstucki
force-pushed
the
rework-reflect-constant
branch
5 times, most recently
from
becf516 to
c7c057e
Compare
The current definition of Constant.unapply is unsound because there is no way to tests if the constant contains a `Type`. We added `Constant.ClassTag.unapply` to work around this limitation, but the original was still unsound. That definition has it's own design flaws. To properly match all constants we provide an extractor for each kind of constant. This has the added advantage of being able to scale if new constants are added later. We also rename `Constant.ClassTag` to `ClassOf` as it represent a `classOf[T]`.
nicolasstucki
force-pushed
the
rework-reflect-constant
branch
from
c7c057e to
edff735
Compare
rssh
added a commit
to dotty-cps-async/dotty-cps-async
that referenced
this pull request
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current definition of Constant.unapply is unsound because there is no way to tests if the constant contains a
Type.We added
Constant.ClassTag.unapplyto work around this limitation, but the original was still unsound.That definition has it's own design flaws.
To properly match all constants we provide an extractor for each kind of constant.
This has the added advantage of being able to scale if new constants are added later.
We also rename
Constant.ClassTagtoClassOfas it represent aclassOf[T].