Skip to content

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Oct 6, 2020

This decouples the repositioning from Inlined tree nodes and drops Inlined nodes in FirstTransform

@nicolasstucki nicolasstucki force-pushed the reposition-based-on-tree-source branch 6 times, most recently from a3ac5c8 to 3d5b7b2 Compare October 7, 2020 14:49
@nicolasstucki nicolasstucki self-assigned this Oct 7, 2020
@nicolasstucki nicolasstucki force-pushed the reposition-based-on-tree-source branch 2 times, most recently from 3953123 to 58194ca Compare October 8, 2020 11:38
This makes the workaround for the missing JSR-45 support slightly less precise.
nicolasstucki and others added 9 commits October 8, 2020 16:50
This decouples the repositioning from Inlined tree nodes
In this first step we remove the Inlined trees in FirstTransform just after unpickling.
We also remove the YCheckPositions wich checked that all changes in sources where wrapped in Inline nodes.
This invariant does not hold after FirstTransform anymore.
YCheckPositions was added to make sure that the transformation fases kept the Inlined nodes until erasure which is not needed anymore.
Without Inlined nodes, the current reporting mechanism cannot properly display the position of the original call. This information is still in the tree but is not tracked.
@nicolasstucki nicolasstucki force-pushed the reposition-based-on-tree-source branch from 58194ca to 215def9 Compare October 9, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants