Reposition trees in erasure using source from tree #9954
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
reposition-based-on-tree-source
branch
6 times, most recently
from
a3ac5c8 to
3d5b7b2
Compare
nicolasstucki
force-pushed
the
reposition-based-on-tree-source
branch
2 times, most recently
from
3953123 to
58194ca
Compare
This makes the workaround for the missing JSR-45 support slightly less precise.
This decouples the repositioning from Inlined tree nodes
In this first step we remove the Inlined trees in FirstTransform just after unpickling. We also remove the YCheckPositions wich checked that all changes in sources where wrapped in Inline nodes. This invariant does not hold after FirstTransform anymore. YCheckPositions was added to make sure that the transformation fases kept the Inlined nodes until erasure which is not needed anymore.
Without Inlined nodes, the current reporting mechanism cannot properly display the position of the original call. This information is still in the tree but is not tracked.
nicolasstucki
force-pushed
the
reposition-based-on-tree-source
branch
from
58194ca to
215def9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decouples the repositioning from
Inlinedtree nodes and dropsInlinednodes inFirstTransform