-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove left over ESLint artifacts #7743
Conversation
The CI fails on on checking the circular dependencies :-/ Circle checks are done with a tool called Some observations:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 👍 While you are at it, you could also remove a bunch of // eslint-disable
comments that still linger around..
Ok, done. See commit: 8b79f07 |
With the recent switch to Biome for linting (#7665) we removed eslint. Some plugins and config files were left behin. This PR removes them.
Replaced circular dependency detection tool from
madge
todpdm
since I ran into dependency problems. Newer versions ofmadge
would detect 100+ circular imports, mostly due to type imports which were not reliably ignored. (see this Madge issueSteps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)