Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add in issue templates and badges #30

Merged
merged 1 commit into from
Dec 12, 2022
Merged

chore: add in issue templates and badges #30

merged 1 commit into from
Dec 12, 2022

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Dec 12, 2022

No description provided.

@ckipp01 ckipp01 requested review from adpi2 and tgodzik December 12, 2022 13:34
@ckipp01 ckipp01 marked this pull request as draft December 12, 2022 14:05
@ckipp01
Copy link
Member Author

ckipp01 commented Dec 12, 2022

I have some legit failures here that I'm not sure how they passed CI before.

@tgodzik
Copy link
Contributor

tgodzik commented Dec 12, 2022

I have some legit failures here that I'm not sure how they passed CI before.

Looks like tests started using the last release RC version: Failed to execute goal ch.epfl.scala:bloop-maven-plugin:2.0.0-RC3:bloopInstall

Is that expected? And it's failing to located Scala version, which is a bit weird. Do you need any help with that?

tgodzik
tgodzik approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The failures don't seem to be related.

.github/ISSUE_TEMPLATE/bug_report.yml
@@ -0,0 +1,55 @@
name: 🐛 Bug Report
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably show a bug template in bloop also with maven issue being redirected here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good idea, I'll add that.

@ckipp01
Copy link
Member Author

ckipp01 commented Dec 12, 2022

Looks like tests started using the last release RC version: Failed to execute goal ch.epfl.scala:bloop-maven-plugin:2.0.0-RC3:bloopInstall

Yea... this was my silly mistake. I'm fixing it. I can't call it like this as it will pull the latest, not the self-published one. I'll have another pr soon that fixes this (because I also found another bug). So once I get that other one merged I'll then rebase this on it.

@ckipp01 ckipp01 marked this pull request as ready for review December 12, 2022 17:43
@ckipp01 ckipp01 merged commit 5ca8da8 into scalacenter:main Dec 12, 2022
@ckipp01 ckipp01 deleted the templates branch December 12, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@adpi2 adpi2 Awaiting requested review from adpi2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ckipp01 @tgodzik