Various fixes #31
Merged
Various fixes #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a change I didn't catch in the previous pr due to how I was testing. I wasn't being explicit about the version when running `bloopInstall` so it was using the last published version. This fixes that by using the version that is inside of the pom when you test. The other issue, which the title is about, is that `mojo.getScalacArgs()` can throw now since it attempts to get the scala version set for the module. However, in Java modules there isn't one, so this was blowing up. This fixes that by wrapping that call like we earlier for other calls that can throw. This also fixes some pom settings that were still pointing to the old repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a change I didn't catch in the previous pr due to how I was
testing. I wasn't being explicit about the version when running
bloopInstallso it was using the last published version. This fixesthat by using the version that is inside of the pom when you test.
The other issue, which the title is about, is that
mojo.getScalacArgs()can throw now since it attempts to get the scalaversion set for the module. However, in Java modules there isn't one, so
this was blowing up. This fixes that by wrapping that call like we
earlier for other calls that can throw.
This also fixes some pom settings that were still pointing to the old
repo.