Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix launcher configuration #74

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

mliarakos
Copy link
Contributor

@mliarakos mliarakos commented Jan 5, 2024

Fixes #47

Overview:

  • Add empty default constructor to AppLauncher to prevent the Cannot create instance of class error
  • Prefer loaded config over default config to correctly read the launcher configuration option
  • Update launcher selection logic to be more in line with scala-maven-plugin:
    • use the launcher specified by the launcher configuration option
    • if that doesn't exist or is not defined, fall back to the first launcher from the list of launchers in the configuration
      • for scala-maven-plugin the first launcher is used only if launcher is not defined (vs. also if it doesn't exist)
      • I added the fall back logic with a new warning
      • I can change the behavior to exactly mirror scala-maven-plugin if needed
  • Refactor out emptyLauncher in favor of an Option[AppLauncher]
  • Add test case for launcher configuration

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely missed this PR 😨 Thanks!

LGTM

@tgodzik tgodzik merged commit aa69298 into scalacenter:main Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure with scala-maven-plugin launcher configuration
2 participants