refactor(build): get rid of build warnings and unused things #1968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pr is just some general cleanup. - Moves to slash syntax in sbt - Removes some unused sbt things - Moves some sbt setting inline if they are only used once
tgodzik
approved these changes
Dec 28, 2022
Contributor
tgodzik
left a comment
tgodzik
left a comment
There was a problem hiding this comment.
LGTM! I think we could probably add the scalafix config and job now 🤔
Member
Author
Yea sure! Ha, there already is a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is just some general cleanup.