Fix issue with BE compilations incorrectly reusing successful artifacts #2520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes an issue with best effort compilation not being properly cached, if recompiled from successful compilations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes an issue with best effort compilation not being properly cached, if recompiled from successful compilations.
@tgodzik About the main issue fixed here, I misdiagnosed that issue yesterday (I mentioned a race condition, not what was happening - the issue is consistent, the way I tried to reproduce it with adding and removing a class in another class was not), but thankfully, it's a simple fix.
About the second thing raised here, that sounds like an actual race condition I'm not sure is exclusive to best effort (like you mentioned) and one I'm not sure I would be able to fix quickly, but it seems to me like a later recompilation would fix that.