Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix publish info #247

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Fix publish info #247

merged 2 commits into from
Jul 25, 2023

Conversation

eloots
Copy link
Collaborator

@eloots eloots commented Jul 25, 2023

  • Settings should apply to all sbt projects

@eloots
Fix publish info
d9d1257 
- Settings should apply to all sbt projects
@eloots eloots requested a review from ckipp01 July 25, 2023 11:46
@eloots
Copy link
Collaborator Author

eloots commented Jul 25, 2023

That's better;

sbt:course-management-tools> show developers
[info] docs / developers
[info] 	List(Developer(eloots, Eric Loots, eric.loots@lunatech.com, https://github.com/eloots))
[info] cmta / developers
[info] 	List(Developer(eloots, Eric Loots, eric.loots@lunatech.com, https://github.com/eloots))
[info] core / developers
[info] 	List(Developer(eloots, Eric Loots, eric.loots@lunatech.com, https://github.com/eloots))
[info] cmtc / developers
[info] 	List(Developer(eloots, Eric Loots, eric.loots@lunatech.com, https://github.com/eloots))
[info] functional-tests / developers
[info] 	List(Developer(eloots, Eric Loots, eric.loots@lunatech.com, https://github.com/eloots))
[info] developers
[info] 	List(Developer(eloots, Eric Loots, eric.loots@lunatech.com, https://github.com/eloots))

ckipp01
ckipp01 reviewed Jul 25, 2023
View reviewed changes
build.sbt
import scala.collection.Seq
inThisBuild(
List(
organization := "com.lunatech",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw organization is also set in commonSettings, so you can remove it there and just have it here.

@eloots
Copy link
Collaborator Author

eloots commented Jul 25, 2023

Remaining to do; split out the release CI bit.
Would like to be able to trigger snapshot releases, but not on every single commit to main.
Publishing to Maven Central should only happen when pushing a tag on a commit on main.

@eloots eloots merged commit 1135344 into main Jul 25, 2023
3 checks passed
@eloots eloots deleted the fix-publish-info branch July 25, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckipp01 ckipp01 ckipp01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eloots @ckipp01