Support dependency review #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MPV
added a commit
to MPV/github-dependency-review-for-scala
that referenced
this pull request
Nov 6, 2023
|
Looks like it works, see: EDIT: I spoke too soon. |
In order for dependency review to work, we need to compare the github sha for the pull request. This can be read from the context and set it as the GITHUB_SHA env variable when it exists.
MPV
added a commit
to MPV/github-dependency-review-for-scala
that referenced
this pull request
Nov 6, 2023
Trying out: - scalacenter/sbt-dependency-submission#140 Now with more logging
Merged
|
See follow-up PR: |
FYI: It works when one runs ...where:
|
|
Thank you @adpi2. |
|
Thank you @MPV and @johnpangalos for figuring this out and fixing it. I will cut a release tomorrow morning. |
|
Works really well, here's another example: |
🙏 Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for dependency review to work, we need to compare the github sha for the pull request. This can be read from the context and set it as the GITHUB_SHA env variable when it exists.
Fixes #135