New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer URI over URL for keys to avoid hostname resolution on equals #143

Merged

bjaglin merged 1 commit into scalacenter:master from bjaglin:uri

Jul 7, 2020

Collaborator

bjaglin commented Jul 7, 2020


          prefer URI over URL for keys to avoid hostname resolution on equals

4495ebd

> Two hosts are considered equivalent if both host names can be
> resolved into the same IP addresses; else if either host name can't
> be resolved, the host names must be equal without regard to case; or
> both host names equal to null.

https://docs.oracle.com/javase/6/docs/api/java/net/URL.html#equals(java.lang.Object)

bjaglin force-pushed the uri branch from 396f0fc to 4495ebd Compare

July 7, 2020 14:06

bjaglin marked this pull request as ready for review

July 7, 2020 14:25

bjaglin requested a review from olafurpg

July 7, 2020 14:26

olafurpg approved these changes

View reviewed changes

Contributor

olafurpg left a comment

Thank you for the followup!

bjaglin merged commit 053b0c6 into scalacenter:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet