fix usage of scalafix via another task #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
commented
Jul 15, 2020
| @@ -0,0 +1,14 @@ | |||
| # check that missing rewrites are detected, with or without a warm compilation cache | |||
| > set scalafixOnCompile := false | |||
| -> lintAll | |||
There was a problem hiding this comment.
on master
[info] [info] Non-compiled module 'compiler-bridge_2.12' for Scala 2.12.12. Compiling...
[info] [info] Running scalafix on 2 Scala sources
[error] /tmp/sbt_4021633e/wrapper/src/main/scala/example/Example.scala:3: error: not found: object imported
[error] import imported.Imported
[error] ^
[info] [info] Compilation completed in 14.904s.
[info] [warn] /tmp/sbt_4021633e/wrapper/src/main/scala/example/Example.scala:3:17: Unused import
[info] [warn] import imported.Imported
[info] [warn] ^
[info] [warn] one warning found
[info] [info] Done compiling.
[info] [success] Total time: 20 s, completed Jul 15, 2020, 11:52:59 AM
[error] x sbt-scalafix / wrapper
[error] Cause of test exception: {line 3} Command succeeded but failure was expected
There was a problem hiding this comment.
I investigated where the concurrent Non-compiled module 'compiler-bridge_2.12' for Scala 2.12.12. Compiling.../Done compiling was coming from as it looked like it could race with the bytecode consumption in scalafix. It turns out to be from Test / scalafix, so I added bjaglin@3a0a4c8 to strengthen the test.
Without the fix, the test logs now shows:
[info] [info] Running scalafix on 2 Scala sources
[error] /tmp/sbt_93ed664/wrapper/src/main/scala/example/Example.scala:3: error: not found: object imported
[error] import imported.Imported
[error] ^
[info] [success] Total time: 5 s, completed Jul 15, 2020, 5:29:15 PM
[error] x sbt-scalafix / wrapper
[error] Cause of test exception: {line 3} Command succeeded but failure was expected
Regression of 0cf5501: initial (cold) invocations to a task delegating to scalafix would result in scalafix being called before compilation (because scalafixRunExplicitly == false) causing false negatives.
Through Test/scalafix & then Test/internalDependencyClasspath, scalafixAll evaluates Compile/compile, which could make Compile/scalafix run as expected sometimes before the fix in 68b7e82.
|
(looks like GitHub is having another outage, and my second commit on https://github.com/bjaglin/sbt-scalafix/commits/task-wrappers is not visible here) |
olafurpg
approved these changes
Jul 15, 2020
| if (scalafixRunExplicitly.value) task.dependsOn(compile.in(config)) | ||
| else task | ||
| // sub-task of compile after which bytecode should not be modified | ||
| task.dependsOn(manipulateBytecode.in(config)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression of 0cf5501: initial (cold) invocations to a task delegating to
scalafixwould result inscalafixbeing called before compilation (becausescalafixRunExplicitly == false) causing false negatives.This makes sure compilation is always triggered before
scalafix(no matter how it's called), but depends on the final sub-tak ofcompilein a cycle-free way.