Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

centralize ScalafixInterface memoization within a setting key #409

Merged
merged 5 commits into from
Apr 18, 2024
Merged

centralize ScalafixInterface memoization within a setting key #409

merged 5 commits into from
Apr 18, 2024

Commits on Apr 17, 2024

  1. ScalafixInterface now handles memoization so provider key is redundant

    @bjaglin
    bjaglin committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    6e05af8 View commit details
    Browse the repository at this point in the history

  2. rely on persistent cache and stamping for custom toolclasspath amorti… 

    …zation

The persistent cache is now bound to a setting key so that its lifecycle is
aligned with an sbt session (allowing flushing via a `reload`)

The per-invocation cache is merged into the persistent one, which means that
the local rules classloader will now remain warm/JITed across invocations. The
cache key and the stamping strategy prevents instances from leaking when local
rules are being iterated on and recompiled between invocations.
    @bjaglin
    bjaglin committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    5bb9167 View commit details
    Browse the repository at this point in the history

  3. use same interface for normal and compilation-less, informational ones

    @bjaglin
    bjaglin committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    52d677b View commit details
    Browse the repository at this point in the history

  4. move existing comment closer to where it actually applies

    @bjaglin
    bjaglin committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    ff8e682 View commit details
    Browse the repository at this point in the history

  5. use ConcurrentHashMap to parallelize invocations with different tool … 

    …classpaths
    @bjaglin
    bjaglin committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    d834da8 View commit details
    Browse the repository at this point in the history