Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leverage cli_3.x.y #430

Merged
merged 2 commits into from
Aug 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion project/Dependencies.scala
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import sbt._

object Dependencies {
val x = List(1) // scalafix:ok
def scalafixVersion: String = "0.12.1"
def scalafixVersion: String = "0.12.1+81-c6766833-SNAPSHOT"

val all = List(
"org.eclipse.jgit" % "org.eclipse.jgit" % "5.13.3.202401111512-r",
Expand Down
8 changes: 1 addition & 7 deletions src/main/scala/scalafix/internal/sbt/ScalafixInterface.scala
Original file line number Diff line number Diff line change
Expand Up @@ -159,13 +159,7 @@ object ScalafixInterface {
None
case None =>
// cache miss, resolve scalafix artifacts and classload them
if (scalafixScalaBinaryVersion.startsWith("3"))
logger.error(
"To use Scalafix on Scala 3 projects, you must unset `scalafixScalaBinaryVersion`. " +
"Rules such as ExplicitResultTypes requiring the project version to match the Scalafix " +
"version are unsupported for the moment."
)
else if (scalafixScalaBinaryVersion == "2.11")
if (scalafixScalaBinaryVersion == "2.11")
logger.error(
"Scala 2.11 is no longer supported. Please downgrade to the final version supporting " +
"it: sbt-scalafix 0.10.4."
Expand Down
14 changes: 4 additions & 10 deletions src/main/scala/scalafix/sbt/ScalafixPlugin.scala
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,13 @@ object ScalafixPlugin extends AutoPlugin {
"Can be set in ThisBuild or at project-level."
)
@deprecated(
"scalafixScalaBinaryVersion now follows scalaBinaryVersion by default",
"scalafixScalaBinaryVersion now follows scalaVersion by default",
"0.12.1"
)
val scalafixScalaBinaryVersion: SettingKey[String] =
settingKey[String](
"The Scala binary version used for scalafix execution. Must be set at project-level. " +
"Custom rules must be compiled against that binary version. Defaults to 2.12 for 2.12 projects, " +
"2.13 otherwise."
"The Scala version used for scalafix execution. Must be set at project-level. " +
"Custom rules must be compiled against that binary version. Defaults to the project's scalaVersion."
)
val scalafixConfig: SettingKey[Option[File]] =
settingKey[Option[File]](
Expand Down Expand Up @@ -268,12 +267,7 @@ object ScalafixPlugin extends AutoPlugin {
},
ivyConfigurations += ScalafixConfig,
scalafixAll := scalafixAllInputTask.evaluated,
(scalafixScalaBinaryVersion: @nowarn) := {
scalaBinaryVersion.value match {
case "2.12" => "2.12"
case _ => "2.13"
}
}
(scalafixScalaBinaryVersion: @nowarn) := scalaVersion.value
)

override lazy val globalSettings: Seq[Def.Setting[_]] = Seq(
Expand Down
1 change: 1 addition & 0 deletions src/sbt-test/sbt-scalafix/resolvers/project/plugins.sbt
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
resolvers += Resolver.sonatypeRepo("public")
addSbtPlugin("ch.epfl.scala" % "sbt-scalafix" % sys.props("plugin.version"))
9 changes: 8 additions & 1 deletion src/sbt-test/sbt-scalafix/scalafixEnable/build.sbt
Original file line number Diff line number Diff line change
@@ -1,28 +1,35 @@
val V = _root_.scalafix.sbt.BuildInfo

lazy val config = project
lazy val config = project.settings(
scalafixScalaBinaryVersion := scalaBinaryVersion.value // to support old scalafix-interface
)

lazy val unsupported = project.settings(
scalafixScalaBinaryVersion := scalaBinaryVersion.value, // to support old scalafix-interface
// 2.11.x is not supported
scalaVersion := "2.11.12"
)

lazy val bumpScala = project.settings(
scalafixScalaBinaryVersion := scalaBinaryVersion.value, // to support old scalafix-interface
// semanticdb-scalac_2.12.0 was never available
scalaVersion := "2.12.0"
)

lazy val downgradeScalameta = project.settings(
scalafixScalaBinaryVersion := scalaBinaryVersion.value, // to support old scalafix-interface
// semanticdb-scalac_2.12.4 no longer available after 4.1.9
scalaVersion := "2.12.4"
)

lazy val upgradeScalameta = project.settings(
scalafixScalaBinaryVersion := scalaBinaryVersion.value, // to support old scalafix-interface
// semanticdb-scalac_2.12.15 not yet available in 4.4.10, became available as of 4.4.28
scalaVersion := "2.12.15"
)

lazy val available = project.settings(
scalafixScalaBinaryVersion := scalaBinaryVersion.value, // to support old scalafix-interface
// semanticdb-scalac_2.13.4 available in 4.4.10
scalaVersion := "2.13.4",
crossScalaVersions := Seq("2.12.15")
Expand Down
2 changes: 2 additions & 0 deletions src/sbt-test/skip-windows/caching/test
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,7 @@ $ delete rules/src/main/scala/local/NoOp.scala
$ delete src/main/scala

# make sure cache is invalidated after changing scalafix version
> set scalafixScalaBinaryVersion := scalaBinaryVersion.value // to support old scalafix-interface
> set scalafixConfig := None
$ mkdir src/main/scala
$ copy-file files/Valid.scala src/main/scala/Valid.scala
Expand All @@ -354,6 +355,7 @@ $ exec chmod 000 src/main/scala/Valid.scala
$ delete src/main/scala

# make sure cache is invalidated after changing scalafix version when no custom dependency is set
> set scalafixScalaBinaryVersion := scalaBinaryVersion.value // to support old scalafix-interface
> set scalafixConfig := None
$ mkdir src/main/scala
$ copy-file files/Valid.scala src/main/scala/Valid.scala
Expand Down