Use configured repositories from sbt build #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scala3 migration plugin gave a false suggestion for how to migrate Akka libraries. Instead of saying that the latest 2.9.4 version was a valid scala 3 library it suggested to downgrade to a version as early as 2.6.18 up to the version 2.9.0-M2. These version are the ones that are published to the maven central that this plugin are hard coded to. Later version of akka are published to https://repo.akka.io/maven. This patch is using the configured repository in the sbt build to resolve the dependencies and are thereby able to find the correct versions. Now: ``` sbt:test-project> migrateDependencies test-project [info] [info] Starting migration of libraries and compiler plugins in project 'test-project' [info] [info] Valid dependencies: ... [info] "com.typesafe.akka" %% "akka-cluster-typed" % "2.9.4" ... ``` Before this commit, older akka versions published to maven central was suggested by the migration tool ``` [warn] Versions to update: ... [warn] "com.typesafe.akka" %% "akka-cluster-typed" % "2.6.17" (Other versions: 2.6.18, ..., 2.9.0-M2) ... ```
|
I tested the latest release today and it found all the latest jars via my configured repos in the sbt build. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement of #484
I moved
LibraryMigrationfrommigratetosbt-pluginso that we can use all configured repositories directly (Maven, and Ivy) and authentication without going through the Java interface.