Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail fast on wrong sourceroot #298

Closed
olafurpg opened this issue Aug 18, 2017 · 0 comments
Closed

Fail fast on wrong sourceroot #298

olafurpg opened this issue Aug 18, 2017 · 0 comments
Labels
cli
Milestone
v0.5.0

Comments

@olafurpg
Copy link
Contributor

Currently, if you pass in a wrong sourceroot then the inputs then some files to be fixed may not have semantic information. Scalafix will still continue to run semantic rewrites, which get no lookup matches in SemanticCtx, perform no diff, and scalafix exits with code 0, OK.

Scalafix should fail fast if a file to be fixed has no associated semantic information.
@olafurpg olafurpg added the cli label Aug 18, 2017
@olafurpg olafurpg modified the milestone: v0.5 Aug 18, 2017
@olafurpg olafurpg mentioned this issue Aug 18, 2017
Merged
olafurpg added a commit that referenced this issue Aug 18, 2017
@olafurpg
Merge pull request #301 from olafurpg/sourceroot-fail-fast
3310ebd 
Fix #298
bjaglin pushed a commit to liancheng/scalafix that referenced this issue May 23, 2023
@scala-steward
Update sbt-scalafmt to 2.5.0 (scalacenter#298)
ff3d738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli
Projects
None yet
Milestone
v0.5.0
Development

No branches or pull requests
1 participant
@olafurpg