make it possible to use testkit with ScalaTest 3.2.x #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Deprecate existing *RuleSuite as they cause runtime failure when used in a classpath where ScalaTest 3.0.x gets evicted by 3.2.x * testkit clients must now mix-in themselves an implementation of TestRegistration (as this trait moved between 3.0.x & 3.2.x) like [Any]FunSuiteLike * Run https://github.com/scalatest/autofix/tree/master/3.1.x on unit
bjaglin
commented
Jun 23, 2020
| @@ -52,6 +52,8 @@ object Mima { | |||
| ProblemFilters.exclude[DirectMissingMethodProblem]("scalafix.testkit.SemanticRuleSuite.LintAssertion"), | |||
| ProblemFilters.exclude[MissingClassProblem]("scalafix.testkit.package$"), | |||
| ProblemFilters.exclude[MissingClassProblem]("scalafix.testkit.package"), | |||
| ProblemFilters.exclude[MissingTypesProblem]("scalafix.testkit.DiffAssertions"), | |||
There was a problem hiding this comment.
[error] * the type hierarchy of interface scalafix.testkit.DiffAssertions is different in current version. Missing types {org.scalatest.TestSuite,org.scalatest.Alerting,org.scalatest.Informing,org.scalatest.TestRegistration,org.scalatest.Notifying,org.scalatest.FunSuiteLike,org.scalatest.Documenting}
bjaglin
commented
Jun 23, 2020
| @@ -52,6 +52,8 @@ object Mima { | |||
| ProblemFilters.exclude[DirectMissingMethodProblem]("scalafix.testkit.SemanticRuleSuite.LintAssertion"), | |||
| ProblemFilters.exclude[MissingClassProblem]("scalafix.testkit.package$"), | |||
| ProblemFilters.exclude[MissingClassProblem]("scalafix.testkit.package"), | |||
| ProblemFilters.exclude[MissingTypesProblem]("scalafix.testkit.DiffAssertions"), | |||
| ProblemFilters.exclude[MissingTypesProblem]("scalafix.testkit.SemanticRuleSuite"), | |||
There was a problem hiding this comment.
[error] * the type hierarchy of class scalafix.testkit.SemanticRuleSuite is different in current version. Missing types {org.scalatest.FunSuite}
There was a problem hiding this comment.
I am surprised not to see SyntacticRuleSuite show up...
bjaglin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1172.
I ran MiMa locally against 0.9.17 and
will open a separate PR to re-introduce it#1177.*RuleSuiteas they cause runtime failure when used in a classpath where ScalaTest 3.0.x gets evicted by 3.2.xTestRegistration(as this trait moved between 3.0.x & 3.2.x) like[Any]FunSuiteLikeunit