check the whole caret position in the testkit #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gontard
force-pushed
the
check-caret-range-in-testkit
branch
2 times, most recently
from
ca99e78 to
5ca9257
Compare
gontard
force-pushed
the
check-caret-range-in-testkit
branch
from
5ca9257 to
367c004
Compare
bjaglin
reviewed
Oct 20, 2020
Replace the example in the documentation by a real one from the tests
olafurpg
approved these changes
Oct 20, 2020
bjaglin
approved these changes
Oct 20, 2020
|
@olafurpg I have added the 1.0.0 milestone on this PR and added a bullet point in the outstanding tasks for the 1.0.0 release. Can you think of any other breaking change we should document so we can tag it as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request ensures that the testkit checks the whole caret (
^^^^) position range. Before only the range start was tested.