Kill and make sure that the presentation compiler is interrupted befo… #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re starting a new thread fixes scalacenter#1229
olafurpg
approved these changes
Nov 4, 2020
|
👏 Maybe we can add a test that exercises this code path many times to cause a OutOfMemory in CI if that ever regresses? |
|
for CI, we fork each test. it's hard to see the OOM. |
tgodzik
added a commit
to tgodzik/metals
that referenced
this pull request
Feb 4, 2021
This is based on scalacenter/scalafix#1272 Previous solution did not actually kill the presentation compiler thread.
tgodzik
added a commit
to tgodzik/metals
that referenced
this pull request
Feb 4, 2021
This is based on scalacenter/scalafix#1272 Previous solution did not actually kill the presentation compiler thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…re starting a new thread
fixes #1229