Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Scala 2.13.4 #1291

Merged
merged 2 commits into from
Nov 27, 2020
Merged

Upgrade to Scala 2.13.4 #1291

merged 2 commits into from
Nov 27, 2020

Conversation

mlachkar
Copy link
Collaborator

Similar to #1179

@mlachkar mlachkar mentioned this pull request Nov 26, 2020
Closed
@mlachkar mlachkar requested a review from bjaglin November 26, 2020 10:06
@mlachkar
Copy link
Collaborator Author

@bjaglin I need help on the mima ci issue. I don't understand why it's still try to download /semanticdb-scalac-core_2.13.4/4.3.24.

Thanks

@bjaglin
Copy link
Collaborator

bjaglin commented Nov 26, 2020 •
edited
Loading

@bjaglin I need help on the mima ci issue. I don't understand why it's still try to download /semanticdb-scalac-core_2.13.4/4.3.24.

Thanks

@mlachkar I think you need to update

scalafix/project/ScalafixBuild.scala

Line 271 in 4c2eb94

"2.13.4" -> "2.13.3"

@mlachkar
Copy link
Collaborator Author

I think I don't fully understand the PreviousScalaVersion Map. It could be empty, it would give the same result.

@bjaglin
Copy link
Collaborator

bjaglin commented Nov 27, 2020

I think I don't fully understand the PreviousScalaVersion Map. It could be empty, it would give the same result.

Indeed, my suggestion didn't make sense. I'll have a look at that today.

@bjaglin
Copy link
Collaborator

bjaglin commented Nov 27, 2020

It looks like a regression in MiMa introduced in lightbend-labs/mima#508 - see last commit details. I'll follow up there, for the time being I think it's easier to downgrade.

daddykotex and others added 2 commits November 27, 2020 10:33
@daddykotex @github-brice-jaglin
Upgrade to Scala 2.13.4
a227388
@github-brice-jaglin
downgrade MiMa to fix 2.13.4 upgrade
bbee966 
MiMa 0.8.0 introduced a regression: mimaPreviousClassfiles fails,
trying to resolve previous, released artifacts with 2.13.4 despite
explicitly setting 2.13.3 in mimaPreviousArtifacts.
@mlachkar
Copy link
Collaborator Author

If it's ok for you, we can merge and then release ?

@bjaglin
Copy link
Collaborator

bjaglin commented Nov 27, 2020

If it's ok for you, we can merge and then release ?

sure of course!

@mlachkar mlachkar merged commit 837df07 into scalacenter:master Nov 27, 2020
@daddykotex
Copy link
Contributor

Thanks for the hard work 👍

@bjaglin bjaglin mentioned this pull request Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjaglin bjaglin Awaiting requested review from bjaglin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mlachkar @bjaglin @daddykotex @github-brice-jaglin