Fix RemoveUnusedPatternVars

[vincenzobaz]

This PR aims at fixing #1343 by using a more general regexp and adding several tests.

closes #1343

[mlachkar]

@vincenzobaz can you check why the tests are failing .. I find that strange the renameSuite is failing. Can you also run bin/scalafmt. Thanks

[mlachkar]

I am having troubles understanding the failing tests with this PR. The change should not affect the other tests, but it's the case.
When debugging, the list of diagnostics is empty in the failing tests.
In my tests, the semanticdb files were produce during compilation time, not by interactive.global.
I am quite blocked by this bug. @bjaglin what do you think we should do ?

[mlachkar]

same code, but the tests are passing #1355
The only difference: I removed the newly added file in tests, that make other tests fail

[mlachkar]

So after further debugging: in fact when adding these new case tests, we don't have warnings anymore on some files...

[mlachkar]

I have just removed a number of tests that were added by this pull request.
Something in those tests was making the compiler not producing anymore "unused warning" for other files.

[bjaglin]

Something in those tests was making the compiler not producing anymore "unused warning" for other files.

Could it be a limit in the compiler output? https://docs.scala-lang.org/overviews/compiler-options/index.html

-Xmaxwarns ARG

Maximum warnings to print
Default: 100

[mlachkar]

I think it should be that! completly forgot about this :s
Pushing again with the entire file test

[mlachkar]

It also means that this rule fixes maximum 100 warns by default (in each run)^^

[bjaglin]

It also means that this rule fixes maximum 100 warns by default (in each run)^^

#1264

We could mention it in the docs at least?