Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "better error for external rules ran with old scalafix-cli version" #1632

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

rvacaru
Copy link
Contributor

@rvacaru rvacaru commented Jul 15, 2022

This reverts commit 6055d854eaa6865372cfd120fc18d379b39d657b .

We are reverting this change for better error messages because we don't want to convert the macros of MetaconfigCompatMacros when cross compiling scalafix-core to scala3.

The risk of not having meaningful errors anymore is now limited due to:

@bjaglin
Copy link
Collaborator

bjaglin commented Jul 15, 2022

The MiMa errors related to the removal of package.scala should be false positives since the methods defined there were shadowing the ones available in scalameta, so you can add exclusions in https://github.com/scalacenter/scalafix/blob/main/project/Mima.scala to silence them and fix the CI

@bjaglin bjaglin merged commit 759f864 into scalacenter:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants