Clean up tests #165
Merged
Clean up tests #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, it always bugged me that misformatted file errors blocked tests. This change makes it so that scalafmt is only run on a single entry in the build matrix
- scalafix-testkit no longer interfaces with the ScalahostPipeline API.
Instead, we use sbt-scalahost to build a mirror and buildinfo to
generate the necessary mappings between original and expected code.
This results in a cleaner test setup:
- no more .source files without syntax highlighting and auto-completion.
- less duplication wrapping every unit test in `object a { }`
- cleaner compiler errors in input/output projects
- easier to use custom classpath for single test suite, just add
a new project!
- Remove old organize imports. OrganizeImports was implemented before
Symbols came and the current implementation is weird adaptation from
the old ScalafixMirror that no longer exists. Instead of keeping this
cruft, this commit removes the import patches with less ambitious
patch implementation that are still somewhat useful.
- Remove more legacy. - Support SKIP and ONLY. - Throw error at end of test suite if some test is marked as ONLY
|
cc/ @ShaneDelmore scalafix-testkit just got a whole lot simpler, since it no longer uses |
olafurpg
force-pushed
the
testkit
branch
3 times, most recently
from
92119f9
to
1142a90
Compare
xeno-by
reviewed
May 25, 2017
| implicit class XtensionSeqPatch(patches: Seq[Patch]) { | ||
| def asPatch: Patch = Patch.fromSeq(patches) | ||
| implicit class XtensionSeqPatch(patches: Iterable[Patch]) { | ||
| def asPatch: Patch = Patch.fromIterable(patches) |
There was a problem hiding this comment.
What's the motivation behind Iterable? I wonder what use cases you found for this more general type.
There was a problem hiding this comment.
iirc, I'm using views on Tokens to build patches. Views are not Seq[]
| @@ -0,0 +1,69 @@ | |||
| /* | |||
| rewrites = ExplicitReturnTypes | |||
| */ | |||
Closed
Travis CI kills the jobs. Those tests only run a subset of rewrites anyways. Those tests are incredibly handy for manual testing, less so for automated CI on every PR commit.
This was referenced May 29, 2017
bjaglin
pushed a commit
to liancheng/scalafix
that referenced
this pull request
May 23, 2023
Bumps [coursier/cache-action](https://github.com/coursier/cache-action) from v5 to v6. - [Release notes](https://github.com/coursier/cache-action/releases) - [Commits](coursier/cache-action@v5...730a6a4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scalafix repo has accumulated a lot of successful and not-so-successful experiments over the past year. This PR cleans up what I found to be not-so-successful around our testing infrastructure an imports management: