Refactor test execution #1756
Merged
Refactor test execution #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
force-pushed
the
setup-scala
branch
9 times, most recently
from
5542a7b to
29af940
Compare
bjaglin
force-pushed
the
setup-scala
branch
19 times, most recently
from
d54a069 to
5b712f4
Compare
bjaglin
commented
May 14, 2023
| @@ -34,7 +34,7 @@ class RuleDecoderSuite extends AnyFunSuite { | |||
| assert(expectedName == rules.name.value) | |||
| } | |||
|
|
|||
| test("relative resolves from custom working directory") { | |||
| test("relative resolves from custom working directory", SkipWindows) { | |||
There was a problem hiding this comment.
integration3/test fails on windows because of this
[info] - relative resolves from custom working directory *** FAILED *** (34 milliseconds)
[info] java.nio.file.InvalidPathException: Illegal char <:> at index 2: /D:/a/scalafix/scalafix/scalafix-tests/integration/target/jvm-3/test-classes/
[info] at java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
[info] at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)
[info] at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
[info] at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92)
[info] at java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:232)
[info] at java.base/java.nio.file.Path.of(Path.java:147)
[info] at java.base/java.nio.file.Paths.get(Paths.java:69)
[info] at dotty.tools.dotc.core.MacroClassLoader$.$anonfun$1(MacroClassLoader.scala:25)
[info] at scala.collection.immutable.List.map(List.scala:246)
[info] at dotty.tools.dotc.core.MacroClassLoader$.makeMacroClassLoader(MacroClassLoader.scala:25)
18f178d to
d821d0f
Compare
bjaglin
commented
May 14, 2023
Comment on lines
-165
to
-167
| // TODO: switch defaults to rely on much more simple test input/rules so | ||
| // that we don't need to hardcode a scala version here. | ||
| val sourceDir = "scalafix-tests/input/src/main/scala-2" |
There was a problem hiding this comment.
removing this unlocks #1728
bjaglin
commented
May 14, 2023
Comment on lines
-162
to
-163
| // There is flakyness in CliGitDiffTests and CliSemanticTests | ||
| Test / parallelExecution := false, |
There was a problem hiding this comment.
I only observed flakiness in integration (expected because we have side effects), so I disabled parallel execution there specifically
bjaglin
commented
May 14, 2023
|
|
||
| lazy val docs = projectMatrix | ||
| .in(file("scalafix-docs")) | ||
| .settings( | ||
| noPublishAndNoMima, | ||
| fork := true, |
There was a problem hiding this comment.
prevents
[error] scala.reflect.internal.MissingRequirementError: object scala.runtime in compiler mirror not found.
[error] at scala.reflect.internal.MissingRequirementError$.notFound(MissingRequirementError.scala:24)
[error] at scala.reflect.internal.Mirrors$RootsBase.$anonfun$getModuleOrClass$6(Mirrors.scala:63)
[error] at scala.reflect.internal.Mirrors$RootsBase.getPackage(Mirrors.scala:63)
[error] at scala.reflect.internal.Definitions$DefinitionsClass.RuntimePackage$lzycompute(Definitions.scala:200)
[error] at scala.reflect.internal.Definitions$DefinitionsClass.RuntimePackage(Definitions.scala:200)
[error] at scala.reflect.internal.Definitions$DefinitionsClass.RuntimePackageClass$lzycompute(Definitions.scala:201)
[error] at scala.reflect.internal.Definitions$DefinitionsClass.RuntimePackageClass(Definitions.scala:201)
[error] at scala.reflect.internal.Definitions$DefinitionsClass.AnnotationDefaultAttr$lzycompute(Definitions.scala:1389)
[error] at scala.reflect.internal.Definitions$DefinitionsClass.AnnotationDefaultAttr(Definitions.scala:1388)
[error] at scala.reflect.internal.Definitions$DefinitionsClass.syntheticCoreClasses$lzycompute(Definitions.scala:1553)
[error] at scala.reflect.internal.Definitions$DefinitionsClass.syntheticCoreClasses(Definitions.scala:1552)
[error] at scala.reflect.internal.Definitions$DefinitionsClass.symbolsNotPresentInBytecode$lzycompute(Definitions.scala:1596)
[error] at scala.reflect.internal.Definitions$DefinitionsClass.symbolsNotPresentInBytecode(Definitions.scala:1596)
[error] at scala.reflect.internal.Definitions$DefinitionsClass.init(Definitions.scala:1652)
[error] at scala.tools.nsc.Global$Run.<init>(Global.scala:1236)
[error] at scala.tools.nsc.interactive.Global$TyperRun.<init>(Global.scala:1351)
[error] at scala.tools.nsc.interactive.Global.newTyperRun(Global.scala:1374)
[error] at scala.tools.nsc.interactive.Global.<init>(Global.scala:294)
[error] at scala.meta.interactive.InteractiveSemanticdb$.newCompiler(InteractiveSemanticdb.scala:34)
[error] at scalafix.docs.PatchDocs$.compiler$lzycompute(PatchDocs.scala:118)
[error] at scalafix.docs.PatchDocs$.compiler(PatchDocs.scala:117)
[error] at docs.Main$.main(Main.scala:59)
[error] at docs.Main.main(Main.scala)
[error] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[error] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[error] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[error] at java.base/java.lang.reflect.Method.invoke(Method.java:566)
[error] stack trace is suppressed; run last docs2_13 / Compile / run for the full output
4049325 to
2494b7f
Compare
bjaglin
force-pushed
the
setup-scala
branch
2 times, most recently
from
ec8c956 to
85b867e
Compare
- integration: seggregate slow, I/O tests (`shared` folded into it) - expect: stop building & running target-independant suites twice - BaseCliSuite no longer relies on teskit (except for basic diff features), to focus on actual CLI interactions rather than input/output checks handled in `expect`
- make all expect tests explicit with sbt-projectmatrix - keep only the 3 latest patch versions as targets (instead of 7) - run tests for all scala versions on windows - move away from one command per scala version - run docs checks in a separate CI job - speed up test execution by removing forking and limiting sequential run to `integration` suites - speed up windows test execution by avoiding compiling upfront scala 3 projects as part of publishLocalTransitive (`publishLocal / skip`) and by expressing the dependency to `publishLocalTransitive` only where needed by hooking into the task graph (`testWindows`) instead of using a sequential command
bjaglin
commented
Jun 7, 2023
Comment on lines
+234
to
+235
| publishLocal / skip := (if ((publishLocal / skip).value) true | ||
| else scalaBinaryVersion.value == "3"), |
There was a problem hiding this comment.
this turned out to have no effect as its intent is already achieved by the line just above, see #1776
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1593
Unlocks #1728 (see comment)
On the
projectsGraphPngbelowinterfacetocliA_Bis not visible