Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix testkit sample to be workable #180

Merged
merged 1 commit into from
May 31, 2017
Merged

fix testkit sample to be workable #180

merged 1 commit into from
May 31, 2017

Conversation

taisukeoe
Copy link
Contributor

@taisukeoe taisukeoe commented May 31, 2017 •
edited
Loading

This fixes several points to make samples work.

  • Remove dotty output directory from test case and add a note about it.
  • Add scalafix configuration requirement in input source files.
  • Add an explanation about output source files.

This PR is also made at open source spree at CPH. Thanks @olafurpg for guiding me. :)

olafurpg
olafurpg approved these changes May 31, 2017
View reviewed changes
Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

@olafurpg olafurpg merged commit 2b72a60 into scalacenter:master May 31, 2017
@taisukeoe taisukeoe deleted the fix-testkit-sample branch May 31, 2017 15:12
@olafurpg olafurpg modified the milestone: v0.4.1 Jun 7, 2017
bjaglin pushed a commit to liancheng/scalafix that referenced this pull request May 23, 2023
@scala-steward
Update sbt-scoverage to 1.8.1 (scalacenter#180)
dc6ac8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olafurpg olafurpg olafurpg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@taisukeoe @olafurpg