allow Scala nightlies via system properties #1865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @SethTisue |
bjaglin
force-pushed
the
upstream-communitybuild-sysprod
branch
from
081cb67 to
bbc480c
Compare
bjaglin
commented
Sep 10, 2023
project/Dependencies.scala
Outdated
| @@ -8,7 +8,7 @@ import scala.util.Try | |||
|
|
|||
| object Dependencies { | |||
| val scala212 = "2.12.18" | |||
| val scala213 = "2.13.12" | |||
| val scala213 = sys.props.getOrElse("scala.nightly", "2.13.12") | |||
There was a problem hiding this comment.
not sure how scala-steward will handle that, but since the bump is manual during the embargo, it does not matter much
bjaglin
force-pushed
the
upstream-communitybuild-sysprod
branch
from
bbc480c to
acbee63
Compare
bjaglin
changed the title
bjaglin
commented
Sep 10, 2023
| val scala213 = "2.13.12" | ||
| val scala3 = "3.3.1" | ||
| val scala212 = sys.props.getOrElse("scala212.nightly", "2.12.18") | ||
| val scala213 = sys.props.getOrElse("scala213.nightly", "2.13.12") |
There was a problem hiding this comment.
@SethTisue I have suffixed the system property with the scala version to make it possible to tweak any scala version, I assume this is not a problem as it's explicitly forwarded there so it can easily be changed?
SethTisue
approved these changes
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scala/community-build#1673