latest scalameta introduces new items in tree hierarchy #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
force-pushed
the
latestscalameta
branch
from
3b95834
to
b8f9f5f
Compare
bjaglin
changed the title
bjaglin
changed the title
bjaglin
changed the title
kitbellew
reviewed
Sep 22, 2024
| @@ -171,7 +171,7 @@ final class ExplicitResultTypes( | |||
| defn.hasMod(mod"implicit") && !isImplicitly(body) | |||
|
|
|||
| def hasParentWihTemplate: Boolean = | |||
| defn.parent.exists(_.is[Template]) | |||
| defn.parent.exists(_.is[Template.Body]) | |||
There was a problem hiding this comment.
i added a convenience implicit so you can just say def.parent.is[].
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scalameta/scalameta#3913 adds new elements in the tree hierarchy, effectively changing the parent of
Template.statsCtor.Secondary.statsType.Match.casesType.Refine.statsType.Existential.statsPkg.statsTemplate.earlyTerm.Match.casesTerm.Try.catchpTerm.PartialFunction.casesTerm.For.enumsTerm.ForYield.enums