scalafix-interfaces: improve docs & be more liberal in parsing #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
force-pushed
the
scalaversion-moreliberal
branch
2 times, most recently
from
0b9743d to
5143a2c
Compare
bjaglin
changed the title
bjaglin
force-pushed
the
scalaversion-moreliberal
branch
from
5143a2c to
ba5f810
Compare
Even though not documented, but since "major.minor" / source-compatibility is non-standard (we need more than "binary" as all Scala 3 versions are binary- compatible) and can be confusing, this supports using just a major version.
bjaglin
force-pushed
the
scalaversion-moreliberal
branch
from
ba5f810 to
733099f
Compare
bjaglin
commented
Sep 29, 2024
| scalaVersionKey = "scala213"; | ||
| } else if (requestedScalaVersion.startsWith("3.0") || | ||
| requestedScalaVersion.startsWith("3.1") || |
There was a problem hiding this comment.
this was capturing by mistake the upcoming 3.10 for example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.