Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't reject Scala 2 nightlies for community build #2109

Merged
merged 1 commit into from
Oct 23, 2024
Merged

don't reject Scala 2 nightlies for community build #2109

merged 1 commit into from
Oct 23, 2024

Conversation

bjaglin
Copy link
Collaborator

@bjaglin bjaglin commented Oct 22, 2024 •
edited
Loading

Closes #2107

@bjaglin bjaglin linked an issue Oct 22, 2024 that may be closed by this pull request
ScalaVersion rejects Scala 2 nightlies #2107
Closed
@bjaglin
Copy link
Collaborator Author

bjaglin commented Oct 22, 2024

@SethTisue is that enough to get you further?

@bjaglin bjaglin marked this pull request as ready for review October 22, 2024 22:55
SethTisue
SethTisue approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I tried this in a local run and that gets me unstuck, thank you!

@bjaglin bjaglin merged commit c42a615 into scalacenter:main Oct 23, 2024
9 checks passed
@bjaglin bjaglin mentioned this pull request Nov 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethTisue SethTisue SethTisue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ScalaVersion rejects Scala 2 nightlies
2 participants
@bjaglin @SethTisue