Add DottyEnumKeyword rewrite, fixes #247. #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me, should this be generalized to other keywords, like |
|
We could also have a compound "DottyKeyword" composing this and other ones like inline |
DottyKeywords backticks identifiers which are upcoming keywords in Dotty. Note that DottyKeywords will rename `@inline` to ```scala @`inline` def foo ``` This compiles with both scalac and dotc, but looks weird. In the future, we may want the rewrite to be semantic and insert `inline` for codebases targeting only Dotty and keep `@scala.inline` (unbackticked) for codebases that want to target both compilers.
With -language:Scala2, Dotty permits inline as part of annotations. This works for both scala.inline as well as custom annotations that are incidentallly named inline. We can later provide a separate rewrite for writing `@scala.inline def` as `inline def` for those who only wish to target Dotty.
|
Thanks for the feedback! I like the idea of a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could someone from the Dotty team maybe review, @smarter?