No unit insertion as an addition of no auto tupling #352
Conversation
|
I'll take a better look from a computer, but it looks 👌 I'm thinking we can probably merge this into NoAutoTupling and just rename the whole thing NoArgumentListAdaptation or something along those lines. WDYT @olafurpg? |
|
Also many thanks @insdami for picking this up, it's a really nice addition to Scalafix! |
There was a problem hiding this comment.
Thank you for this contribution @insdami ! I am hiking this weekend at Scala World so my responses may be slow :)
I agree with @gabro, can we merge this with NoAutoTupling? We can keep the test suite separate, however. We may want to consider renaming the rewrite to NoAdaptedArgs eventually, but that can be left for a future PR.
Otherwise this PR looks great!
| ctx.addRight(t.tokens.init.last, "()") | ||
|
|
||
| override def fix(ctx: RuleCtx): Patch = { | ||
| val adaptations = index.messages.toIterator.collect { |
There was a problem hiding this comment.
This will iterate through all reported messages in the workspace/project on every source file, we should move it outside of the fix method.
There was a problem hiding this comment.
Sure, I'll do the same in NoAutoTupling
This PR is for #214.
I'm not quite sure how to compose it with
NoAutoTuplingto run it usingNoAdaptedArgsas you propose on the comments.Have a look at it and let me know, please :)