Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AppVeyor as a CI on Windows #585

Merged
merged 5 commits into from
Feb 1, 2018
Merged

Add AppVeyor as a CI on Windows #585

merged 5 commits into from
Feb 1, 2018

Conversation

MasseGuillaume
Copy link
Contributor

@MasseGuillaume MasseGuillaume commented Jan 30, 2018 •
edited
Loading

@MasseGuillaume MasseGuillaume force-pushed the appveyor branch 22 times, most recently from 3be43a0 to 7b03d16 Compare January 30, 2018 18:44
@MasseGuillaume
Copy link
Contributor Author

Progress:
https://ci.appveyor.com/project/scalacenter/scalafix/build/26/job/gb6tyfttsrdsg25o#L6885

[error] Failed tests:
[error] 	scalafix.tests.reflect.ScalafixReflectTests
[error] 	scalafix.tests.cli.CliGitDiffTests
[error] 	scalafix.tests.cli.CliSemanticTests
[error] 	scalafix.tests.core.PatchSuite
[error] 	scalafix.tests.reflect.ToolClasspathTests

@MasseGuillaume MasseGuillaume mentioned this pull request Jan 31, 2018
Closed
@MasseGuillaume MasseGuillaume changed the title Add AppVeyor as a CI on Window Add AppVeyor as a CI on Window / Fix Scalafix on Window Jan 31, 2018
@MasseGuillaume MasseGuillaume changed the title Add AppVeyor as a CI on Window / Fix Scalafix on Window Fix Scalafix on Window Jan 31, 2018
@MasseGuillaume MasseGuillaume changed the title Fix Scalafix on Window WIP: Fix Scalafix on Window Jan 31, 2018
@MasseGuillaume
Copy link
Contributor Author

Related:

@MasseGuillaume MasseGuillaume changed the title WIP: Fix Scalafix on Window Add AppVeyor as a CI on Window Jan 31, 2018
@MasseGuillaume
Add AppVeyor as a CI on Window
4685714 
* Bump coursier to 1.0.0, why not?
* Remove comment in .jvmopts because of: sbt/sbt#3908
* Disable tests not running on Windows
  * scalafix.tests.reflect.ScalafixReflectTests
  * scalafix.tests.cli.CliGitDiffTests
  * scalafix.tests.cli.CliSemanticTests
  * scalafix.tests.core.PatchSuite
  * scalafix.tests.reflect.ToolClasspathTests
olafurpg
olafurpg reviewed Jan 31, 2018
View reviewed changes
.travis.yml Outdated

- CI_TEST: scalafmt

- CI_TEST: scalafixTest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this run scalafixTest for all scala versions and JS + JVM? I thought we had to run scalafix/scalafixTest

README.md
@@ -1,6 +1,7 @@
scalafix
[![Latest version](https://index.scala-lang.org/scalacenter/scalafix/scalafix-core/latest.svg)](https://index.scala-lang.org/scalacenter/scalafix/scalafix-core)
[![Build Status](https://travis-ci.org/scalacenter/scalafix.svg?branch=master)](https://travis-ci.org/scalacenter/scalafix)
[![Travis Build Status](https://travis-ci.org/scalacenter/scalafix.svg?branch=master)](https://travis-ci.org/scalacenter/scalafix)
[![AppVeyor Build Status](https://ci.appveyor.com/api/projects/status/laoidnw0txrcxmxa/branch/master?svg=true)](https://ci.appveyor.com/project/scalacenter/scalafix/branch/master)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

olafurpg
olafurpg reviewed Jan 31, 2018
View reviewed changes
project/ScalafixBuild.scala Outdated
commands += Command.command("ci-sbt-windows") { s =>
// scripted tests don't work in sbt 1.0 yet because we run Sbt1
"scalafix-sbt/publishLocal" ::
testSkipWindows("scalafix-sbt") ::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we skip scripted tests on windows?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no this is scalafix-sbt/test

project/ScalafixBuild.scala Outdated
testSkipWindows("scalafix") ::
s
},
commands += Command.command("ci-fast-211-windows") { s =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe only run 2.12 + JVM on windows?

olafurpg
olafurpg reviewed Jan 31, 2018
View reviewed changes
appveyor.yml Outdated
matrix:
- CI_TEST: ci-fast-212
# - CI_TEST: ci-fast-211 to shave some time
- CI_TEST: ci-sbt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we skip this? The sbt 1 entry doesn't run any tests iirc

@olafurpg
Copy link
Contributor

olafurpg commented Feb 1, 2018

Seems like we'll have to add a method overload for checkDiff in testkit to please mima https://travis-ci.org/scalacenter/scalafix/jobs/335659555#L799 we can keep the original signature that forwards to another checkDiff that has at least one non-variadic Tag

@olafurpg
Copy link
Contributor

olafurpg commented Feb 1, 2018

The appveyor failure is reproducing #583 https://ci.appveyor.com/project/scalacenter/scalafix/build/33/job/ddm4qbjd2hqxyfao#L5494 Can we can disable it for now and I will try and fix it in a followup PR

olafurpg
olafurpg approved these changes Feb 1, 2018
View reviewed changes
Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is green 👍 Failures are minor

@MasseGuillaume MasseGuillaume merged commit cb06307 into scalacenter:master Feb 1, 2018
@MasseGuillaume MasseGuillaume deleted the appveyor branch February 1, 2018 14:16
@fommil
Copy link
Contributor

fommil commented Feb 8, 2018

btw take a look at any of my appveyor setups (particularly ensime-server or ensime-sbt) to see how to get symlinks to work. Look for magical git commands in the preamble.

@MasseGuillaume
Copy link
Contributor Author

@fommil the symlink was not used, I just removed it.

@MasseGuillaume MasseGuillaume changed the title Add AppVeyor as a CI on Window Add AppVeyor as a CI on Windows Mar 15, 2018
@olafurpg olafurpg added this to the v0.6.0-M2 milestone Apr 11, 2018
@bjaglin bjaglin mentioned this pull request Nov 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olafurpg olafurpg olafurpg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.0-M2
Development

Successfully merging this pull request may close these issues.
3 participants
@MasseGuillaume @olafurpg @fommil