Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for semantic rewriting of .sbt files. #664

Merged
merged 1 commit into from
Mar 22, 2018

Conversation

olafurpg
Copy link
Contributor

@olafurpg olafurpg commented Mar 22, 2018

Support for semantic rules for .sbt files never worked robustly.
It's not on the roadmap to improve the situation so it's best to remove
this functionality altogether.

Fixes #645.

@olafurpg olafurpg requested a review from MasseGuillaume March 22, 2018 15:58
Support for semantic rules for .sbt files never worked robustly.
It's not on the roadmap to improve the situation so it's best to remove
this functionality altogether.
@olafurpg olafurpg requested review from gabro and removed request for MasseGuillaume March 22, 2018 16:32
Copy link
Collaborator

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 Fewer features, more profit

@olafurpg
Copy link
Contributor Author

A lot of removed code today 😎 🔥

@olafurpg olafurpg merged commit 752acc8 into scalacenter:master Mar 22, 2018
@olafurpg olafurpg deleted the semanticdb-sbt branch March 22, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants